Multi selection #145
Merged
Multi selection #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The UI-tests are polluted by the JupyterLab 4 update notification |
IIRC there is a config to disable the notification popup |
martinRenou
force-pushed
the
multi_selection
branch
from
8546eb9
to
dc9631d
Compare
|
Visual regression is legit now |
|
Converting to draft, I want to add support for multi-selection in the tree view and add a visual regression test for it. |
martinRenou
force-pushed
the
multi_selection
branch
from
c2169bb
to
c54d83b
Compare
martinRenou
force-pushed
the
multi_selection
branch
from
c54d83b
to
ef9aae5
Compare
martinRenou
force-pushed
the
multi_selection
branch
from
ef9aae5
to
3a2474b
Compare
|
update snapshots again again |
|
@trungleduc This is ready! |
|
The PR also fixes an issue with selection bouncing between the tree and the 3d view |
|
please update snapshots again |
|
@trungleduc green again |
trungleduc
approved these changes
May 26, 2023
|
Thanks @martinRenou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.from.2023-05-16.09-49-16.webm
Fix #131 and fix #137