Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar refactor and styling #129

Merged
merged 10 commits into from
May 5, 2023
Merged

Toolbar refactor and styling #129

merged 10 commits into from
May 5, 2023

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Apr 25, 2023 •
edited
Loading

Would fix #125 and fix #49

  • Turn toolbar buttons into JupyterLab commands
  • Move commands logic in its own file
  • Improve the UI and UX of the toolbar (no dropdown, new icons, less clicks)

Screenshot from 2023-05-05 12-53-14

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/toolbar

martinRenou
martinRenou commented Apr 26, 2023
View reviewed changes
examples/ArchDetail.FCStd Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those changes should not be committed

@martinRenou
Copy link
Member Author

martinRenou commented May 5, 2023 •
edited
Loading

Remaining TODO:

  • Rebase and fix conflicts 😄
  • Refactor user toolbar
  • Spacers in the toolbar
  • Get rid of console warnings
  • Pencil icon is grey

@martinRenou martinRenou marked this pull request as ready for review May 5, 2023 11:12
@martinRenou
Copy link
Member Author

I probably need to update the integration tests and screenshots, but the rest is ready to review.

@martinRenou
Copy link
Member Author

please update snapshots

@trungleduc
Copy link
Member

Thanks @martinRenou

@trungleduc trungleduc merged commit 6632078 into jupytercad:main May 5, 2023
@martinRenou martinRenou deleted the toolbar branch May 9, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

@hbcarlos hbcarlos Awaiting requested review from hbcarlos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve UI toolbar The "PART" dropdown does support clicking on the "caret" icon
2 participants
@martinRenou @trungleduc