Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploded view #109

Merged
merged 10 commits into from
Jan 31, 2023
Merged

Exploded view #109

merged 10 commits into from
Jan 31, 2023

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Jan 26, 2023

Fix #38

jupytercad-screenshot

TODO:

  • Fix annotations positions in exploded view
  • Added UI controls for enabling/disabling the exploded view and changing its factor
  • Sync exploded view state with other clients (for the follow mode) won't do
  • Fix pointer position by taking the exploded view into account
  • Update exploded view when mesh visibility changes
  • Update exploded view when mesh removal change?

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/exploded_view

@martinRenou
Copy link
Member Author

martinRenou commented Jan 26, 2023

  • Fix annotations positions in exploded view
  • Fix pointer position by taking the exploded view into account

Those two points require that the annotations and pointer are attached to a specific mesh, in order to know how they should be exploded. So I need to change a bit the models of pointers and annotations.

@martinRenou
Copy link
Member Author

The last two commits make the 3D pointers aware of the picked mesh, this allows showing the collaborators pointers at the correct position whether we are in exploded view or not:

Screenshot from 2023-01-27 11-35-56

(right side is picking: left side is showing the right picked position relative to the selected mesh)

@trungleduc trungleduc marked this pull request as ready for review January 31, 2023 12:14
@trungleduc
Copy link
Member

Thanks @martinRenou, it looks great!

@trungleduc trungleduc merged commit d9e3177 into jupytercad:main Jan 31, 2023
@martinRenou martinRenou deleted the exploded_view branch February 1, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add exploded view
2 participants