Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add launcher buttons #108

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Add launcher buttons #108

merged 3 commits into from
Feb 20, 2023

Conversation

hbcarlos
Copy link
Contributor

Fixes #100

The FCStd file doesn't work because as you can see here, we create a new file by calling the save method in the contents service and passing an empty document.

The Freecad format is a standard zip file containing one or more files in a specific structure, there is no easy way of hardcoding this in the frontend.

Maybe this is a good opportunity to improve the RTC API.

@hbcarlos hbcarlos self-assigned this Jan 25, 2023
@hbcarlos hbcarlos marked this pull request as draft January 25, 2023 12:13
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch hbcarlos/jupytercad/fix_100

@trungleduc
Copy link
Member

The Freecad format is a standard zip file containing one or more files in a specific structure, there is no easy way of hardcoding this in the frontend.

I think creating jcad file is enough, we can have a Save as button in the toolbar and then export the FCStd file from the backend.

@trungleduc
Copy link
Member

Hi @hbcarlos, what is the status of this PR?

@hbcarlos
Copy link
Contributor Author

hbcarlos commented Feb 6, 2023

We can remove the icon for creating FCStd files and merge or wait for a solution to this problem upstream.

@trungleduc
Copy link
Member

I would go with the jcad only launcher for now.

@hbcarlos hbcarlos marked this pull request as ready for review February 6, 2023 12:34
@trungleduc
Copy link
Member

I just tried from Binder and It does not seem to open correctly the existing files.

error.mp4

@hbcarlos
Copy link
Contributor Author

hbcarlos commented Feb 8, 2023

I just tried from Binder and It does not seem to open correctly the existing files.

It should work now.

@trungleduc
Copy link
Member

Thanks @hbcarlos

@trungleduc trungleduc merged commit bf30298 into jupytercad:main Feb 20, 2023
@hbcarlos hbcarlos deleted the fix_100 branch February 20, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new empty file
2 participants