Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve theme handling 3D view and tree view #10

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Improve theme handling 3D view and tree view #10

merged 1 commit into from
Oct 5, 2022

Conversation

martinRenou
Copy link
Member

This PR does two things:

  • Fixes support for other themes than "JupyterLab Light" and "JupyterLab Dark"
  • Adds support for theme switching for the Tree view
dark_theme.mp4

@trungleduc
Copy link
Member

Thanks!

@trungleduc trungleduc merged commit 4a09a81 into jupytercad:main Oct 5, 2022
@martinRenou martinRenou deleted the theme_handling branch October 5, 2022 14:38
martinRenou pushed a commit to martinRenou/jupytercad that referenced this pull request Dec 6, 2022
@trungleduc
Merge pull request jupytercad#10 from martinRenou/theme_handling
c23018d 
Improve theme handling 3D view and tree view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @trungleduc