Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pymc.sample docs are incorrect -- waiting for upstream fix #380

Open
HumphreyYang opened this issue Dec 18, 2023 · 6 comments
Open

pymc.sample docs are incorrect -- waiting for upstream fix #380

HumphreyYang opened this issue Dec 18, 2023 · 6 comments

Comments

@HumphreyYang
Copy link
Collaborator

Hi @mmcky,

pymc.sample is deprecated after v5.10.0 as shown here.

@HumphreyYang
Copy link
Collaborator Author

HumphreyYang commented Dec 18, 2023

Hi @mmcky,

Strangely, after testing it under pymc-5.10.2, I found pymc.sample can still be called. It is only removed from the documentation.

pymc.sampling.mcmc.sample does the same thing, perhaps it is calling pymc.sampling.mcmc.sample at the backend.

Would you still like me to update it?

@mmcky
Copy link
Contributor

mmcky commented Dec 19, 2023

@HumphreyYang may we should report this to the pymc project?

@mmcky
Copy link
Contributor

mmcky commented Dec 4, 2024

@HumphreyYang would you mind to update this

The link in ar1_bayes is not working as indicated above.

https://www.pymc.io/projects/docs/en/stable/projects/docs/en/v5.10.0/api/generated/pymc.sampl.html#pymc-sample

@HumphreyYang
Copy link
Collaborator Author

Thanks @mmcky, I will do it.

I submitted a PR to pymc a year ago but it still hasn't been merged : )

@mmcky
Copy link
Contributor

mmcky commented Dec 4, 2024

Roger that.

Has the routine been renamed due to deprecation? Should we be using a different method?

@HumphreyYang
Copy link
Collaborator Author

Roger that.

Has the routine been renamed due to deprecation? Should we be using a different method?

No, they updated the structure of their documentation (unintentionally), the methods are not changed : )

@mmcky mmcky changed the title pymc.sample deprecated after v5.10.0 pymc.sample docs are incorrect -- waiting for upstream fix Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants