Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AR1 Bayes lecture comments #252

Open
jstac opened this issue Aug 19, 2022 · 2 comments
Open

AR1 Bayes lecture comments #252

jstac opened this issue Aug 19, 2022 · 2 comments

Comments

@jstac
Copy link
Contributor

jstac commented Aug 19, 2022

@thomassargent30 @Smit-create, I really enjoyed reading the lecture https://python.quantecon.org/ar1_bayes.html

Some minor suggestions:

It is not clear from reading the lecture why we are using both pymc and numpyro. Is it because they give different insights or because we want to show how to use both libraries? Some guidance for the reader would be helpful.

It would help the reader if there was a bit more guidance about the numpyro implementation. E.g., what is NUTS? Just one or two lines, and perhaps a few links?

Add "the" to "The first component of statistical model"

@Smit-create
Copy link
Member

Hi @jstac
Thanks for opening up this issue. I'll try to go through the lecture once and modify it according to your suggestions.

It is not clear from reading the lecture why we are using both pymc and numpyro. Is it because they give different insights or because we want to show how to use both libraries? Some guidance for the reader would be helpful.

Taking a very high-level look at the lecture, it seems that we are trying to show how to use two different libraries to solve the same problem (not sure).

@jstac
Copy link
Contributor Author

jstac commented Aug 20, 2022

Thanks @Smit-create . @thomassargent30 let me know that he plans to address these comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants