Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lecture review] footnote in-text citation styles #66

Closed
shlff opened this issue Jun 8, 2021 · 5 comments · Fixed by #124
Closed

[lecture review] footnote in-text citation styles #66

shlff opened this issue Jun 8, 2021 · 5 comments · Fixed by #124
Assignees
Labels
enhancement New feature or request

Comments

@shlff
Copy link
Member

shlff commented Jun 8, 2021

Hi @jstac and @mmcky , I also find that the in-text citation styles of footnotes in MYST lectures look different from those in RST lectures before.

e.g., please see knowing_forecasts_of_others's footnote 1 (left: RST; right: MYST):
Screen Shot 2021-06-08 at 11 32 31 am

As discussed with @AakashGfude , we think it would be better to follow the styles in RST lectures--to put the in-text footnote citations in the superscript (as what we did in the picture on the left-hand side above).

Do you think it is a good idea? Looking forward to your comments.

@mmcky
Copy link
Contributor

mmcky commented Jun 8, 2021

hey @shlff I think replicating the styles from rst would be great 👍

@mmcky mmcky added the enhancement New feature or request label Jun 11, 2021
@mmcky
Copy link
Contributor

mmcky commented Sep 6, 2022

there is actually currently an issue with rendering the footnotes

QuantEcon/quantecon-book-theme#180

@jstac
Copy link
Contributor

jstac commented Sep 28, 2022

Hi @AakashGfude , could you please update us on this issue?

@AakashGfude
Copy link
Member

AakashGfude commented Oct 7, 2022

Hi @jstac @mmcky , the build locally for me seems to be working fine.
Screen Shot 2022-10-07 at 11 54 15 am

but in the website, it is broken. Strange.

EDIT: The screenshot is from an earlier branch. The latest main branch, its broken locally as well. Will have a look.

@jstac
Copy link
Contributor

jstac commented Oct 7, 2022

Thanks @AakashGfude, I hope you can find the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants