Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final quadrature cleanup #31

Open
3 tasks
sglyon opened this issue Jul 30, 2014 · 2 comments
Open
3 tasks

Final quadrature cleanup #31

sglyon opened this issue Jul 30, 2014 · 2 comments

Comments

@sglyon
Copy link
Member

sglyon commented Jul 30, 2014

I have reviewed the quadrature branch and I think that code is ready to merge.

There are a couple of things that we should still clean up soon, but that shouldn't prevent the branch from being merged. Here are the residual clean-up items:

  • In the docstring for qnwequi we don't know what the equidist_pp argument does.
  • We need to fill in a description of the docstring for ce_util.gridmake
  • The example notebook has a lot of code and pretty pictures, but not much exposition. It could use some love to make it a better teaching tool.
@mmcky
Copy link
Contributor

mmcky commented Mar 15, 2016

@spencerlyon2 Are these items still outstanding? Can I close this issue. It appears there is a merged PR.

@sglyon
Copy link
Member Author

sglyon commented Mar 15, 2016

Yes, I think we still need to clean up that notebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants