Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Change: remove STDIO operation from GDAXDownloaderProgram #12

Open
3 tasks done
PaoloOranges opened this issue Jul 30, 2023 · 0 comments
Open
3 tasks done

Comments

@PaoloOranges
Copy link

PaoloOranges commented Jul 30, 2023

It would be beneficial to move all the dependency from STDIO (ie Console.ReadLine() and Console.WriteLine()) from GDAXDownloaderProgram to Program.cs.
It would remove dependency from GDAXDownloaderProgram allow it to be called in other functions and not depends on user input to return

Expected Behavior

GDAXDownloaderProgram.GDAXDownloader(tickers, resolution, fromDate, toDate); would return without having to wait for IO from Console

Actual Behavior

GDAXDownloaderProgram.GDAXDownloader(tickers, resolution, fromDate, toDate); does not return after finishing downloading data since it wait for Console.ReadLine

Potential Solution

Move IO Console operation to Program.cs.
Since the change is no more than 5 min: #13
I will close the PR if refactor is not accepted

Reproducing the Problem

System Information

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant