You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be beneficial to move all the dependency from STDIO (ie Console.ReadLine() and Console.WriteLine()) from GDAXDownloaderProgram to Program.cs.
It would remove dependency from GDAXDownloaderProgram allow it to be called in other functions and not depends on user input to return
Expected Behavior
GDAXDownloaderProgram.GDAXDownloader(tickers, resolution, fromDate, toDate); would return without having to wait for IO from Console
Actual Behavior
GDAXDownloaderProgram.GDAXDownloader(tickers, resolution, fromDate, toDate); does not return after finishing downloading data since it wait for Console.ReadLine
Potential Solution
Move IO Console operation to Program.cs.
Since the change is no more than 5 min: #13
I will close the PR if refactor is not accepted
Reproducing the Problem
System Information
Checklist
I have completely filled out this template
I have confirmed that this issue exists on the current master branch
I have confirmed that this is not a duplicate issue by searching issues
The text was updated successfully, but these errors were encountered:
It would be beneficial to move all the dependency from STDIO (ie
Console.ReadLine()
andConsole.WriteLine()
) fromGDAXDownloaderProgram
toProgram.cs
.It would remove dependency from
GDAXDownloaderProgram
allow it to be called in other functions and not depends on user input to returnExpected Behavior
GDAXDownloaderProgram.GDAXDownloader(tickers, resolution, fromDate, toDate);
would return without having to wait for IO from ConsoleActual Behavior
GDAXDownloaderProgram.GDAXDownloader(tickers, resolution, fromDate, toDate);
does not return after finishing downloading data since it wait forConsole.ReadLine
Potential Solution
Move IO Console operation to
Program.cs
.Since the change is no more than 5 min: #13
I will close the PR if refactor is not accepted
Reproducing the Problem
System Information
Checklist
master
branchThe text was updated successfully, but these errors were encountered: