-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curate JupyterLab themes #133
Comments
Is this UI specific or syntax highlighting too? |
At the JupyterLab accessibility call on June 29, 2022 we discussed some themes people might want so that we can begin collecting them. Here is the list pulled from the meeting notes:
I'd also like to add some other ideas based on additional discussions I've had over the past year or so.
|
One more thought! I gave quick look to what themes are already out there as JupyterLab extensions, and I'm finding none that are specifically accessibility focused and few that mention accessibility as a consideration. This means we can't rule any of the above prompts out based on them already existing in the community. (If you find an example of this, though, I'd love to hear I'm wrong.) |
Based on further discussion, here's a first pass at some criteria I'd like to propose we a) review JupyterLab with and b) curate and review our theme extensions based on. It's all up for critique, but I'd like to request special attention to the WCAG 2.2 guidelinesMust be includedThe following guidelines are the minimum scope I believe we should consider for labelling a default theme "accessible." Since I think they are required, I've abbreviated many of them for length's sake. Full text is available in the links.
Reach goalsI would like to meet these guidelines, but given time and resource constraints I'm not confident we'll be able to yet. I do want them flagged as further work wherever these efforts live.
Exception: Human languages and scripts that do not make use of one or more of these text style properties in written text can conform using only the properties that exist for that combination of language and script. Up for discussionFor the following guidelines, I'm unsure if they are within scope for a JuptyerLab theme extension. While they are all at least partially theming issues, they have some reason I'm not confident they fit our current goals. For example, many of these would be repeat fixes across extensions which seems like an ineffective approach when compared to fixing it in core JupyterLab.
Except for parts of the content which require two-dimensional layout for usage or meaning.
Exception: The visual presentation of the additional content is controlled by the user agent and is not modified by the author.
Additional ideas to incorporateAs has been said many a time, WCAG is not the end-all list of efforts we can take. It is one of the easiest to reference for our use, though, and a good place to start when much of JupyterLab does not address those guidelines as-is. The following are rough ideas of additional criteria we may want to include in our review and extensions.
|
Draft of the checklist version of this scope. Very subject to change, and will become a proper PR shortly. |
I took a close look at this, and I think this needs to be flagged for focussed discussion in one of our team meetings. The reason why is that I don't think I have enough knowledge at the moment about JupyterLab themes and stylesheets to really give this adequate review all by myself. I think to give this adequate review might need all of our combined expertise on this at the same time, asking each other questions in real time. I think it would be super useful for me, for example, to go through the areas (WCAG guidelines) that you have identified one by one, and talk about whether or not we already have some thoughts about how we might address it via a JupyterLab theme extension. |
From meeting on 2022-08-01
📌 Refresher from grant deliverables: Work towards JupyterLab compliance with WCAG 2.1 requirements focused on low-vision and ambulatory users. In scope are:
|
Update: this discussion has moved to the main JupyterLab repo at JupyterLab #10004. |
Summary
Based on sprint planning discussions in #114. Related to #8 and more flexibility to these fixes.
Quoting from #114
Acceptance Criteria
We have at least two themes for JupyterLab developed around accessible prompts. (I could be convinced we should close this at one theme.) At least one of these needs to be the a WCAG contrast compliant set.
Tasks to complete
I think we need to iron this out if it gets added to a sprint.
The text was updated successfully, but these errors were encountered: