restrict node version to ">=12.5.0" #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the "engines" entry to package.json to make node aware of the incompatibility due to Numeric Separators used in this code base, which are supported since NodeJS v12.5.0.
|
Sorry I missed this, yes that's fine. Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the "engines" entry to package.json to make node aware of the incompatibility due to Numeric Separators used in this
code base, which are supported since NodeJS v12.5.0.
I know, you might not care, as NodeJS v12 is the LTS anyway, but it's always better to be explicit in case someone uses an outdated NodeJS version.