Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up infrastructure for Jest (JavaScript) tests #282

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

Prework for #208.

Abby and I decided that we want Jest tests for two purposes:

  1. Checking that web components are in sync between the Pytorch and Furo themes, e.g. we didn't forget to update one of the folders.
    1. We could do this either by using Snapshot testing or by simply checking that the file contents are equal.
  2. We have some non-trivial logic in Fix previous releases sidebar feature for ecosystem projects #267 and want to write automated unit tests.

This PR adds the basic infrastructure, like setting up CI to install Node.js. That will make it easier to review follow-up PRs that add actual tests.

We could do this either by using snapshot testing

I think we'd benefit from adding snapshot testing for the top nav bar rendering correctly. I want to do this in a follow up PR so we can properly decide if we want to add snapshots or not; the decision to use snapshots is separate from whether to use Jest generally.

Copy link
Collaborator

@javabster javabster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Eric-Arellano Eric-Arellano merged commit b5d76bd into Qiskit:main Apr 27, 2023
@Eric-Arellano Eric-Arellano deleted the js-tests branch April 27, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants