Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore original paragraph spacing #206

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

#103 removed a couple CSS rules that were being applied to blockquote, which was intentional.

But in the process, it resulted in p and some elements like ul li losing those rules too, and using the table rule from below. I suspect this was unintentional because there was a blank line between those elements and the table element:

article.pytorch-article dl dt,
article.pytorch-article dl dd

article.pytorch-article table {
   ..
}

This change resulted in paragraphs having a bottom margin of 2.5rem, when we want the theme's default of 1.125rem.

--

This doesn't seem to impact spacing in <ol> and <ul>, but the code before this PR did cause too much space in <dl> (description list). Meanwhile, the code before #103 was bad that it was setting the style for <dt> (term), which resulted in the font not being bolded until #103. So, this PR fixes the spacing, but removes dt from the rule set so that it stays bold.

Before

Screenshot 2023-03-13 at 8 27 54 AM

--

Screenshot 2023-03-13 at 8 35 53 AM

After

Screenshot 2023-03-13 at 8 26 02 AM

--

Screenshot 2023-03-13 at 8 39 26 AM

@Eric-Arellano Eric-Arellano requested a review from javabster March 13, 2023 14:44
@Eric-Arellano
Copy link
Collaborator Author

Thanks @coruscating for the report!

@coruscating
Copy link
Collaborator

Thanks for working on this @Eric-Arellano! Tested locally, and the paragraph spacings are good now with no change to <ul> and <ol> spacing as you described.

@HuangJunye HuangJunye merged commit d7e75f5 into Qiskit:main Mar 13, 2023
@Eric-Arellano Eric-Arellano deleted the fix-paragraph-spacing branch March 13, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants