Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation langs dropdown does not dismiss when clicking elsewhere #310

Closed
woodsp-ibm opened this issue May 10, 2023 · 1 comment
Closed

Comments

@woodsp-ibm
Copy link
Member

woodsp-ibm commented May 10, 2023

In re-deploying Qiskit Optimzation docs I was checking the language dropdown and went to dismiss it by clicking elsewhere on the page. I expected this to dismiss the dropdown, as this is what normally happens in that type of UI. But it did not and at first I thought my browser (or system) had frozen since nothing seemed to be happening. Turns out I either needed to explicitly click on the dropdown down-arrow toggle or a language to dismiss it. I think the dropdown should be dismissed when I click outside of it as would be expected of such a UI element,

@Eric-Arellano
Copy link
Collaborator

The design in the new Furo-based theme (#425) no longer blocks any content:

Screenshot 2023-06-30 at 11 18 10 AM

Screenshot 2023-06-30 at 11 19 15 AM

With the new design, clicking outside the dropdown will not change the toggle state of the dropdown. But because the dropdown no longer covers content, that is how UI typically would work. The designers liked this setup.

So, closed by switching to the new theme 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants