Extended the from_backend method of InstructionDurations to support both BackendV1 and BackendV2 (backport #12941)
#13009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…rt both `BackendV1` and `BackendV2` (#12941) * Extended the `from_backend` method of `InstructionDurations` to support `GenericBackendV2` * Simplified the `from_backend` method to allow using `BackendV2`. Added a test and a releasenote. * Made changes to the releasenote. (cherry picked from commit 6107799)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
Changelog: Bugfix
Pull Request Test Coverage Report for Build 10487878456Details
💛 - Coveralls |
ElePT
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #12760
I have extended the
from_backendmethod ofInstructionDurationsso that it supports bothBackendV1andBackendV2(alsoGenericBackendV2). To get the instruction durations from theBackendV2, I have used the attributetarget. Also, inGenericBackendV2, the(duration, error)fordelayandresetis set to(None, None)and thisNonevalue raises an error in theupdate()method ofInstructionDurations. So, I am skipping the instructions which haveNoneas the duration (let me know if this is not what we want).@1ucian0, please review this and let me know if this is acceptable. If you want I can also add tests and/or new release notes for the changes I have made.
Thanks
Details and comments
This is an automatic backport of pull request #12941 done by [Mergify](https://mergify.com).