Add AnnotatedOperation.params and fix some control issues (backport #12752)
#12828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* AnnotatedOp.params support and Gate.control fix * add reno * lint * update reno * review comments - use attribute error - more clearly state the new None arg in reno and Gate class * review from Elena * Fix ``AttributeError`` test * lint * Apply suggestions from code review Co-authored-by: Elena Peña Tapia <[email protected]> --------- Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit 1512535)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
Changelog: New Feature
ElePT
approved these changes
Jul 26, 2024
Pull Request Test Coverage Report for Build 10114622119Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
AnnotatedOperation.paramsand, leveraging that, fixes some issues when controlling standard gates that are parameterized. Closes #10311, #10697 and #12135.Since this PR also changes
AnnotatedOperationit's probably too large for a backport?Details and comments
AnnotatedOperation.paramsis a proxy to tobase_op.params, if it exists. If thebase_ophas noparams, returns an empty list (as discussed with the team offline).annotatedargument inGate.controlnow isNoneper default, which allows to set it toTruefor gates that cannot be eagerly synthesized. A test for each gate that failed previously is added.S/Sdggates didn't returnCS/CSdggates for a single control, that's also been fixed.This is an automatic backport of pull request #12752 done by [Mergify](https://mergify.com).