-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix C3SXGate
to_matrix
method (backport #12742)
#12744
Conversation
Cherry-pick of d86f995 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9856319240Details
💛 - Coveralls |
Summary
This PR adds the
with_controlled_gate_array
decorator missing inC3SXGate
that enables theto_matrix
method. This bug was found while portingC3SXGate
to Rust (#12659).Details and comments
I have also noticed that the path of
C3SXGate
is incorrect. It's currently inqiskit/circuit/library/standard_gates/x.py
while it should be inqiskit/circuit/library/standard_gates/sx.py
. I did not address this issue in the current PR because I believe the move to the correct location is a breaking change and should probably be left for 2.0 (although most users won't import gates directly from the file).This is an automatic backport of pull request #12742 done by Mergify.