Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing synthesis release notes #12715

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

alexanderivrii
Copy link
Contributor

Summary

Just a few days ago @mtreinish has reminded me (yet again) about the difference between an upgrade note and a feature note:

An upgrade note is reserved for something that we want to document might require user input when upgrading from the previous release to the new one. Examples would be a breaking api change, minimum dependency version bump, etc.

and of course we forgot about this in some of the recently merged PRs (probably because we keep copying and adapting the notes from previously merged PRs).

This tiny PRs classifies the release notes correctly. And attention @Cryoris with #12588.

@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted 😉

@Cryoris Cryoris enabled auto-merge July 3, 2024 09:54
@Cryoris Cryoris added the Changelog: None Do not include in changelog label Jul 3, 2024
@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9775510065

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 89.842%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 3 93.13%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 9775174998: 0.01%
Covered Lines: 65070
Relevant Lines: 72427

💛 - Coveralls

@Cryoris Cryoris added this pull request to the merge queue Jul 3, 2024
Merged via the queue into Qiskit:main with commit 419f40e Jul 3, 2024
15 checks passed
Procatv pushed a commit to Procatv/qiskit-terra-catherines that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants