Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal support for standalone Var to visualisers #12307

Merged
merged 2 commits into from
May 1, 2024

Commits on Apr 29, 2024

  1. Add minimal support for standalone Var to visualisers

    This adds best-effort only support to the visualisers for handling
    stand-alone `Var` nodes.  Most of the changes are actually in `qasm3`,
    since the visualisers use internal details of that to handle the nodes.
    
    This commit decouples the visualisers _slightly_ more from the inner
    workings of the OQ3 exporter by having them manage their own
    variable-naming contexts and using the encapsulated `_ExprBuilder`,
    rather than poking into random internals of the full circuit exporter.
    This is necessary to allow the OQ3 exporter to expand to support these
    variables itself, and also for the visualisers, since variables may now
    be introduced in inner scopes.
    
    This commit does not attempt to solve many of the known problems around
    zero-operand "gates", of which `Store` is one, just leaving it un-drawn.
    Printing to OpenQASM 3 is possibly a better visualisation strategy for
    large dynamic circuits for the time being.
    jakelishman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d5c35b0 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Fix typos

    Co-authored-by: Matthew Treinish <[email protected]>
    jakelishman and mtreinish authored May 1, 2024
    Configuration menu
    Copy the full SHA
    b55bee4 View commit details
    Browse the repository at this point in the history