Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pulse.build() default alignment argument #12029

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

TsafrirA
Copy link
Collaborator

@TsafrirA TsafrirA commented Mar 17, 2024

Summary

Fix #12028 such that pulse.build() will accept AlignmentKind instances as valid input for argument default_alignment.

@TsafrirA TsafrirA requested review from eggerdj, wshanks and a team as code owners March 17, 2024 12:54
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @nkanazawa1989

@TsafrirA TsafrirA added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: pulse Related to the Pulse module labels Mar 17, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8315587198

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 21 unchanged lines in 3 files lost coverage.
  • Overall coverage remained the same at 89.288%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.81%
crates/qasm2/src/lex.rs 2 91.69%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 8310563987: 0.0%
Covered Lines: 59783
Relevant Lines: 66955

💛 - Coveralls

Copy link
Contributor

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bugfix. Alternatively we can make AlignmentKind hashable, but this fix looks more straightforward.

@nkanazawa1989 nkanazawa1989 added this pull request to the merge queue Mar 18, 2024
Merged via the queue into Qiskit:main with commit 00b0952 Mar 18, 2024
12 checks passed
@TsafrirA TsafrirA deleted the BuilderAlignmentBug branch March 18, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: pulse Related to the Pulse module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pulse.build() raises an error when default_alignment is set to AlignmentKind instance
4 participants