Remove old graph structure during EquivalenceLibrary.set_entry
#11959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 8178988151Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
The previous implementation of `EquivalenceLibrary.set_entry` changed the equivalence rules attached to particular nodes within the graph structure, but didn't correctly update the edges, so the graph was no longer representing the correct data, and queries within `BasisTranslator` would still use the old equivalence sets. This correctly clears out the old rules and adds the new structure when `set_entry` is used. The inner private variable `_rule_count` is replaced with `_rule_id`, since it would actually be misleading for its use to decrement it; this could cause clashes, and what's actually intended and used is that it's an id for rules.
jakelishman
force-pushed
the
fix-equivalence-set-entry
branch
from
80eb002
to
b0cc77a
Compare
mtreinish
reviewed
Mar 6, 2024
|
Tested locally and resolves the issue. Nice! |
mtreinish
approved these changes
Mar 6, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
) * Remove old graph structure during `EquivalenceLibrary.set_entry` The previous implementation of `EquivalenceLibrary.set_entry` changed the equivalence rules attached to particular nodes within the graph structure, but didn't correctly update the edges, so the graph was no longer representing the correct data, and queries within `BasisTranslator` would still use the old equivalence sets. This correctly clears out the old rules and adds the new structure when `set_entry` is used. The inner private variable `_rule_count` is replaced with `_rule_id`, since it would actually be misleading for its use to decrement it; this could cause clashes, and what's actually intended and used is that it's an id for rules. * Add test with parallel edges (cherry picked from commit 67e0243)
|
@Mergifyio backport stable/0.46 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
) * Remove old graph structure during `EquivalenceLibrary.set_entry` The previous implementation of `EquivalenceLibrary.set_entry` changed the equivalence rules attached to particular nodes within the graph structure, but didn't correctly update the edges, so the graph was no longer representing the correct data, and queries within `BasisTranslator` would still use the old equivalence sets. This correctly clears out the old rules and adds the new structure when `set_entry` is used. The inner private variable `_rule_count` is replaced with `_rule_id`, since it would actually be misleading for its use to decrement it; this could cause clashes, and what's actually intended and used is that it's an id for rules. * Add test with parallel edges (cherry picked from commit 67e0243)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
) (#11963) * Remove old graph structure during `EquivalenceLibrary.set_entry` The previous implementation of `EquivalenceLibrary.set_entry` changed the equivalence rules attached to particular nodes within the graph structure, but didn't correctly update the edges, so the graph was no longer representing the correct data, and queries within `BasisTranslator` would still use the old equivalence sets. This correctly clears out the old rules and adds the new structure when `set_entry` is used. The inner private variable `_rule_count` is replaced with `_rule_id`, since it would actually be misleading for its use to decrement it; this could cause clashes, and what's actually intended and used is that it's an id for rules. * Add test with parallel edges (cherry picked from commit 67e0243) Co-authored-by: Jake Lishman <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
) (#11962) * Remove old graph structure during `EquivalenceLibrary.set_entry` The previous implementation of `EquivalenceLibrary.set_entry` changed the equivalence rules attached to particular nodes within the graph structure, but didn't correctly update the edges, so the graph was no longer representing the correct data, and queries within `BasisTranslator` would still use the old equivalence sets. This correctly clears out the old rules and adds the new structure when `set_entry` is used. The inner private variable `_rule_count` is replaced with `_rule_id`, since it would actually be misleading for its use to decrement it; this could cause clashes, and what's actually intended and used is that it's an id for rules. * Add test with parallel edges (cherry picked from commit 67e0243) Co-authored-by: Jake Lishman <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
) (#11963) * Remove old graph structure during `EquivalenceLibrary.set_entry` The previous implementation of `EquivalenceLibrary.set_entry` changed the equivalence rules attached to particular nodes within the graph structure, but didn't correctly update the edges, so the graph was no longer representing the correct data, and queries within `BasisTranslator` would still use the old equivalence sets. This correctly clears out the old rules and adds the new structure when `set_entry` is used. The inner private variable `_rule_count` is replaced with `_rule_id`, since it would actually be misleading for its use to decrement it; this could cause clashes, and what's actually intended and used is that it's an id for rules. * Add test with parallel edges (cherry picked from commit 67e0243) Co-authored-by: Jake Lishman <[email protected]>
IsmaelCesar
pushed a commit
to comp-quantica/qiskit-terra
that referenced
this pull request
Mar 13, 2024
…kit#11959) * Remove old graph structure during `EquivalenceLibrary.set_entry` The previous implementation of `EquivalenceLibrary.set_entry` changed the equivalence rules attached to particular nodes within the graph structure, but didn't correctly update the edges, so the graph was no longer representing the correct data, and queries within `BasisTranslator` would still use the old equivalence sets. This correctly clears out the old rules and adds the new structure when `set_entry` is used. The inner private variable `_rule_count` is replaced with `_rule_id`, since it would actually be misleading for its use to decrement it; this could cause clashes, and what's actually intended and used is that it's an id for rules. * Add test with parallel edges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous implementation of
EquivalenceLibrary.set_entrychanged the equivalence rules attached to particular nodes within the graph structure, but didn't correctly update the edges, so the graph was no longer representing the correct data, and queries withinBasisTranslatorwould still use the old equivalence sets.This correctly clears out the old rules and adds the new structure when
set_entryis used. The inner private variable_rule_countis replaced with_rule_id, since it would actually be misleading for its use to decrement it; this could cause clashes, and what's actually intended and used is that it's an id for rules.Details and comments
Fix #11958