Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect final removals from Qiskit 1.0 #11711

Merged
merged 7 commits into from
Feb 1, 2024

Conversation

jakelishman
Copy link
Member

Summary

This is a roll-up of a bunch of extant deprecation warnings that were spotted in the 1.0 branch just before its release. All of these are trivial removals.

There remain one or two pending deprecations, but it's too late to do anything about those. There are also a couple of deprecations in the older timeline drawer for features that are still used in documentation, so I've just left in place.

Details and comments

This was definitely not made after the feature freeze.

giphy

This is a roll-up of a bunch of extant deprecation warnings that were
spotted in the 1.0 branch just before its release.  All of these are
trivial removals.

There remain one or two pending deprecations, but it's too late to do
anything about those.  There are also a couple of deprecations in the
older timeline drawer for features that are still used in documentation,
so I've just left in place.
@jakelishman jakelishman added the Changelog: Removal Include in the Removed section of the changelog label Feb 1, 2024
@jakelishman jakelishman added this to the 1.0.0 milestone Feb 1, 2024
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @enavarro51
  • @Qiskit/terra-core
  • @ikkoham
  • @levbishop
  • @mtreinish
  • @nkanazawa1989

kevinhartman
kevinhartman previously approved these changes Feb 1, 2024
Copy link
Contributor

@kevinhartman kevinhartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

mtreinish
mtreinish previously approved these changes Feb 1, 2024
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small inline suggestion on the release notes. We can save it for post-rc1 assuming this passes CI. If it needs a new commit to pass CI we can apply when we update the branch.

releasenotes/notes/rollup-removals-ce8326ea90c0ad99.yaml Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 1, 2024

Pull Request Test Coverage Report for Build 7747612580

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • -1 of 7 (85.71%) changed or added relevant lines in 6 files are covered.
  • 43 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.386%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/quantum_info/operators/measures.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.81%
crates/qasm2/src/lex.rs 4 92.19%
crates/qasm2/src/parse.rs 12 97.15%
qiskit/synthesis/two_qubit/two_qubit_decompose.py 26 96.63%
Totals Coverage Status
Change from base Build 7746232749: 0.02%
Covered Lines: 60107
Relevant Lines: 67244

💛 - Coveralls

@mtreinish mtreinish dismissed stale reviews from kevinhartman and themself via b653d8f February 1, 2024 20:40
mtreinish
mtreinish previously approved these changes Feb 1, 2024
@kevinhartman kevinhartman added this pull request to the merge queue Feb 1, 2024
Merged via the queue into Qiskit:main with commit 4c410ed Feb 1, 2024
12 checks passed
@jakelishman jakelishman deleted the rollup-removals branch February 1, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants