-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Effect final removals from Qiskit 1.0 #11711
Conversation
This is a roll-up of a bunch of extant deprecation warnings that were spotted in the 1.0 branch just before its release. All of these are trivial removals. There remain one or two pending deprecations, but it's too late to do anything about those. There are also a couple of deprecations in the older timeline drawer for features that are still used in documentation, so I've just left in place.
One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small inline suggestion on the release notes. We can save it for post-rc1 assuming this passes CI. If it needs a new commit to pass CI we can apply when we update the branch.
Pull Request Test Coverage Report for Build 7747612580Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Summary
This is a roll-up of a bunch of extant deprecation warnings that were spotted in the 1.0 branch just before its release. All of these are trivial removals.
There remain one or two pending deprecations, but it's too late to do anything about those. There are also a couple of deprecations in the older timeline drawer for features that are still used in documentation, so I've just left in place.
Details and comments
This was definitely not made after the feature freeze.