Fix SetLayout to error with invalid int list input #11653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue in the SetLayout transpiler pass when an integer list is specified nothing was checking that the integer list contained unique entries. Previously if a list containing duplciate entries was passed in this would result in an invalid Layout object being set on the property set. This would cause a cryptic error message by later transpiler passes that would try and use that invalid Layout. This commit fixes this by detecting if there are duplicate entries in the int list and raising an exception directly.
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7696225893
💛 - Coveralls |
mtreinish
added
the
Changelog: Bugfix
jakelishman
reviewed
Jan 26, 2024
jakelishman
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes an issue in the SetLayout transpiler pass when an integer list is specified nothing was checking that the integer list contained unique entries. Previously if a list containing duplicate entries was passed in this would result in an invalid Layout object being set on the property set. This would cause a cryptic error message by later transpiler passes that would try and use that invalid Layout. This commit fixes this by detecting if there are duplicate entries in the int list and raising an exception directly.
Details and comments