You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseEstimatorV2 is taken from #11227 with the following modifications:
Adds a precision attribute to BaseEstimatorV2 and EstimatorPub
Removes Options from BaseEstimatorV2
Removes unnecessary BasePrimitiveV2 and BasePub classes
The precision attribute is intended to be the API element for controlling estimator precision in algorithms or applications (eg VQE). Previously this intended to be done via shots in Options, however as pointed out in review Options do not define an actual interface API since subclasses can implement them however they like. Subclasses can still implement options (and the runtime estimator will), but they are no longer part of the base API, but rather specific to how an individual estimator can be configured. This means the only API elements of an initialized EstimatorV2 for use in applications are a run method, and a precision getter/setter.
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.
0 of 0 changed or added relevant lines in 0 files are covered.
Why was options removed from the base class? I understand the desire to keep the base class simple, but the user feedback we got was that it's preferred to have some consistency (e.g. same options related attributes/methods) across different primitive implementations. This was also documented in the RFC.
Taken from 11227, but modified to
- remove options from BaseEstimatorV2
- add precision attribute to BaseEstimatorV2 and EstimatorPub
- remove BasePrimitiveV2 and BasePub
Co-Authored-By: Ikko Hamamura <[email protected]>
Co-Authored-By: Ian Hincks <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chriseclectic
added
priority: high
mod: primitives
Summary
Depends on #11524
Adds BaseEstimatorV2 class
Details and comments
BaseEstimatorV2 is taken from #11227 with the following modifications:
precisionattribute to BaseEstimatorV2and EstimatorPubThe
precisionattribute is intended to be the API element for controlling estimator precision in algorithms or applications (eg VQE). Previously this intended to be done via shots in Options, however as pointed out in review Options do not define an actual interface API since subclasses can implement them however they like. Subclasses can still implement options (and the runtime estimator will), but they are no longer part of the base API, but rather specific to how an individual estimator can be configured. This means the only API elements of an initialized EstimatorV2 for use in applications are arunmethod, and aprecisiongetter/setter.