remove PauliList support as observable type for Estimator.run #11521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ucian0
added
the
Changelog: Removal
jakelishman
reviewed
Jan 9, 2024
qiskit/primitives/utils.py
Outdated
Comment on lines
65
to
66
| else: | ||
| if isinstance(observable, PauliList): | ||
| warnings.warn( | ||
| "Implicit conversion from a PauliList to a SparsePauliOp with coeffs=1 in" | ||
| " estimator observable arguments is deprecated as of Qiskit 0.46 and will be" | ||
| " in Qiskit 1.0. You should explicitly convert to a SparsePauli op using" | ||
| " SparsePauliOp(pauli_list) to avoid this warning.", | ||
| DeprecationWarning, | ||
| stacklevel=2, | ||
| ) | ||
| return SparsePauliOp(observable) | ||
| raise QiskitError(f"observable type not supported: {type(observable)}") |
There was a problem hiding this comment.
This is a behavioural change compared to the previous state - the warning only affected PauliList, but the new action forbids anything that hit this else path.
There was a problem hiding this comment.
oh. my bad. Fixed in b5a260d
I got confused because SparsePauliOp still takes PauliList and it seems like an unnecessary constrain not allow PauliList at this point. This new code captures the original spirit @chriseclectic ?
Pull Request Test Coverage Report for Build 7473640080
💛 - Coveralls |
ikkoham
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of the deprecation introduced in #11520 (port of #11055)