Allow string keys in QuantumCircuit.assign_parameters
#11432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
Changelog: New Feature
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7448501896
💛 - Coveralls |
eendebakpt
reviewed
Dec 24, 2023
eendebakpt
reviewed
Dec 24, 2023
These are looked up using the new `get_parameter` method to convert them into an actual `Parameter` instance. This is not available in the fast path (which is allowed to assume that the caller has taken care of providing the most efficient inputs).
jakelishman
force-pushed
the
assign-by-name
branch
from
e91a046
to
ab0af2f
Compare
|
Rebased and ready for review. |
Cryoris
approved these changes
Jan 8, 2024
ShellyGarion
pushed a commit
to ShellyGarion/qiskit-terra
that referenced
this pull request
Jan 18, 2024
These are looked up using the new `get_parameter` method to convert them into an actual `Parameter` instance. This is not available in the fast path (which is allowed to assume that the caller has taken care of providing the most efficient inputs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These are looked up using the new
get_parametermethod to convert them into an actualParameterinstance. This is not available in the fast path (which is allowed to assume that the caller has taken care of providing the most efficient inputs).Details and comments
Depends on #11431, which this PR currently contains.edit: now rebased.Close #7107.