Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text overwriting end of box for empty default case in mpl drawer #11366

Merged
merged 7 commits into from
Jan 2, 2024
Merged

Fix text overwriting end of box for empty default case in mpl drawer #11366

merged 7 commits into from
Jan 2, 2024

Conversation

enavarro51
Copy link
Contributor

Summary

Fixes empty default case

Details and comments

In a SwitchCaseOp with an empty default case, the text would overwrite the end of the box in the mpl circuit drawer as shown below.
image
It now displays thus,
image

@enavarro51 enavarro51 requested review from nonhermitian and a team as code owners December 3, 2023 23:13
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7080039014

  • 3 of 9 (33.33%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.006%) to 87.418%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/circuit/matplotlib.py 3 9 33.33%
Files with Coverage Reduction New Missed Lines %
qiskit/visualization/circuit/matplotlib.py 2 48.13%
crates/qasm2/src/lex.rs 4 90.91%
Totals Coverage Status
Change from base Build 7078267006: -0.006%
Covered Lines: 59910
Relevant Lines: 68533
💛 - Coveralls

jakelishman
jakelishman approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test case seems correct to me, thanks for the fix Edwin!

@jakelishman jakelishman added this pull request to the merge queue Jan 2, 2024
@jakelishman jakelishman added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: visualization qiskit.visualization labels Jan 2, 2024
@jakelishman jakelishman modified the milestones: 0.46.0, 0.45.2 Jan 2, 2024
@jakelishman jakelishman added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Jan 2, 2024
Merged via the queue into Qiskit:main with commit fe2d7f9 Jan 2, 2024
13 checks passed
mergify bot pushed a commit that referenced this pull request Jan 2, 2024
@enavarro51 @mergify
Fix text overwriting end of box for empty default case in mpl drawer (#…
011098e 
…11366)

* Testing

* Fix case default empty

* Add reno

* Lint

(cherry picked from commit fe2d7f9)
@mergify mergify bot mentioned this pull request Jan 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 2, 2024
@mergify @enavarro51
Fix text overwriting end of box for empty default case in mpl drawer (#…
00cc01d 
…11366) (#11482)

* Testing

* Fix case default empty

* Add reno

* Lint

(cherry picked from commit fe2d7f9)

Co-authored-by: Edwin Navarro <[email protected]>
ShellyGarion pushed a commit to ShellyGarion/qiskit-terra that referenced this pull request Jan 18, 2024
@enavarro51 @ShellyGarion
Fix text overwriting end of box for empty default case in mpl drawer (Q…
00928a6 
…iskit#11366)

* Testing

* Fix case default empty

* Add reno

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

@nonhermitian nonhermitian Awaiting requested review from nonhermitian nonhermitian is a code owner

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: visualization qiskit.visualization stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
0.45.2
Development

Successfully merging this pull request may close these issues.
4 participants
@enavarro51 @qiskit-bot @coveralls @jakelishman