update comment in a test file #11317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 8749665399Details
💛 - Coveralls |
mtreinish
reviewed
Nov 28, 2023
| qc = QuantumCircuit(2) | ||
| qc.cz(0, 1) | ||
|
|
||
| bt_pass = BasisTranslator(std_eqlib, target_basis=None, target=self.target) | ||
| output = bt_pass(qc) | ||
| # We need a second run of BasisTranslator to correct gates outside of | ||
| # the target basis. This is a known isssue, see: | ||
| # https://qiskit.org/documentation/release_notes.html#release-notes-0-19-0-known-issues |
There was a problem hiding this comment.
Fwiw the updated release note link is: https://qiskit.org/documentation/legacy_release_notes.html#release-notes-0-19-0-known-issues but I know that won't be valid itself after too long. But the example there is the minimum reproducer of this problem. In practice it only comes up for manually constructed targets though, it's not a real issue as none of the backends I'm aware of have heterogeneous 1q gates.
There was a problem hiding this comment.
Thanks for recovering the original known issue! I moved it to an issue so we keep it with the rest of them and updated the comment.
1ucian0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a fix, but I ran into this problem and I noticed that there was a note in one of the tests. However, the link in the notes is broken. Is #7346 the write issue that is tracking the problem?