Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __qiskit_version__ (deprecated in Qiskit Terra 0.25) #11305

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Nov 23, 2023

Summary

Follow up on #10242

Details and comments

Removal of qiskit.__qiskit_version__, which was deprecated on Qiskit Terra 0.25 (released on July 2023)

@1ucian0 1ucian0 requested a review from a team as a code owner November 23, 2023 10:13
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Nov 23, 2023

Pull Request Test Coverage Report for Build 6968697678

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 86.474%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 92.17%
Totals Coverage Status
Change from base Build 6966472058: 0.03%
Covered Lines: 66253
Relevant Lines: 76616

💛 - Coveralls

@1ucian0 1ucian0 added the Changelog: Removal Include in the Removed section of the changelog label Nov 23, 2023
@ElePT ElePT added this to the 1.0.0 milestone Nov 24, 2023
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT added this pull request to the merge queue Nov 24, 2023
Merged via the queue into Qiskit:main with commit b2a1f75 Nov 24, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants