Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the discrete pulse library #11277

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

TsafrirA
Copy link
Collaborator

Summary

This PR removes the discrete pulse library, following its deprecation in Qiskit 0.46.

Details and comments

The discrete pulse library has been pending deprecation since #10222 and deprecated in #11110 as part of Qiskit 0.46 (backported in #11265).

The release note added in #11110 was removed in favor of removal note. The deprecation note will remain in the 0.46 branch.

@TsafrirA TsafrirA requested review from eggerdj, wshanks and a team as code owners November 19, 2023 18:53
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @nkanazawa1989

@coveralls
Copy link

coveralls commented Nov 19, 2023

Pull Request Test Coverage Report for Build 6922488289

  • 4 of 8 (50.0%) changed or added relevant lines in 1 file are covered.
  • 18 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 85.88%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/pulse/library/parametric_pulses.py 4 8 50.0%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
crates/qasm2/src/lex.rs 5 91.67%
qiskit/pulse/library/continuous.py 12 80.22%
Totals Coverage Status
Change from base Build 6911016807: -0.01%
Covered Lines: 65846
Relevant Lines: 76672

💛 - Coveralls

@nkanazawa1989 nkanazawa1989 added Changelog: Removal Include in the Removed section of the changelog mod: pulse Related to the Pulse module labels Nov 20, 2023
Copy link
Contributor

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the followup.

@nkanazawa1989 nkanazawa1989 added this pull request to the merge queue Nov 20, 2023
Merged via the queue into Qiskit:main with commit f453b11 Nov 20, 2023
14 checks passed
@TsafrirA TsafrirA deleted the RemoveDiscreteLibrary branch November 20, 2023 07:11
FabianBrings pushed a commit to FabianBrings/qiskit that referenced this pull request Nov 27, 2023
* Remove the discrete pulses library

* Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog mod: pulse Related to the Pulse module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants