Add representation of storage-owning Var nodes
#10944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
the
mod: circuit
|
One or more of the the following people are requested to review this:
|
jakelishman
added
the
Changelog: New Feature
This was referenced Oct 2, 2023
This adds the representation of `expr.Var` nodes that own their own storage locations, and consequently are not backed by existing Qiskit objects (`Clbit` or `ClassicalRegister`). This is the base of the ability for Qiskit to represent manual classical-value storage in `QuantumCircuit`, and the base for how manual storage will be implemented.
jakelishman
force-pushed
the
var/repr
branch
from
c95b99c
to
dc31205
Compare
Pull Request Test Coverage Report for Build 7019349075Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
mtreinish
reviewed
Nov 27, 2023
There was a problem hiding this comment.
Overall this LGTM just a few comments on the docs. Did you want to include a release note for this change to explain the new features on the Var class? Or are you doing a single combined note at the end (I feel like it might be easier to have one file that's incrementally updated for each PR).
Edit: NM about the release note, I see that was addressed in the PR summary.
Co-authored-by: Matthew Treinish <[email protected]>
mtreinish
approved these changes
Nov 28, 2023
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Jan 29, 2024
This commit is a roll-up reversion of the following commits (PR): * This reverts commit a79e879 (Qiskit#10977) * This reverts commit ba161e9 (Qiskit#10974) * This reverts commit 50e8137 (Qiskit#10944) This is being done to clear the 1.0 branch of memory-owning `expr.Var` variables and `Store` instructions. It should be re-applied once 1.0 is released. The individual reverts had conflicts, since various other large-scale changes include wrap-ups of the changes to be reverted. This reversion should have handled all that, and other places where standalone `Var` nodes were referenced (such as in "See also" sections), even if not used.
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Jan 29, 2024
This commit is a roll-up reversion of the following commits (PR): * commit a79e879 (Qiskit#10977) * commit ba161e9 (Qiskit#10974) * commit 50e8137 (Qiskit#10944) This is being done to clear the 1.0 branch of memory-owning `expr.Var` variables and `Store` instructions. It should be re-applied once 1.0 is released. This wasn't done by individual `revert` operations, because there were also significant structural changes introduced in those PRs that were very valid and should be maintained. Cross-references to `Var` nodes from other functions have been removed for now. Making `Var` and `types.Type` hashable is maintained, as is the `Var.standalone` function, in order to prepare the ground for the inclusion of proper `Var` nodes in a minor release.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
This commit is a roll-up reversion of the following commits (PR): * commit a79e879 (#10977) * commit ba161e9 (#10974) * commit 50e8137 (#10944) This is being done to clear the 1.0 branch of memory-owning `expr.Var` variables and `Store` instructions. It should be re-applied once 1.0 is released. This wasn't done by individual `revert` operations, because there were also significant structural changes introduced in those PRs that were very valid and should be maintained. Cross-references to `Var` nodes from other functions have been removed for now. Making `Var` and `types.Type` hashable is maintained, as is the `Var.standalone` function, in order to prepare the ground for the inclusion of proper `Var` nodes in a minor release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the representation of
expr.Varnodes that own their own storage locations, and consequently are not backed by existing Qiskit objects (ClbitorClassicalRegister). This is the base of the ability for Qiskit to represent manual classical-value storage inQuantumCircuit, and the base for how manual storage will be implemented.Details and comments
Close #10923.
The release note will be added as part of closing epic #10922.