Removed 2pi wrapping for global phase parameter

[Raghav-Bell]

It fixes #10569

Summary

Removed _mod_2pi function.

Details and comments

It is similiar to Qiskit/qiskit-ibm-provider#689

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

• @Qiskit/terra-core

[coveralls]

Pull Request Test Coverage Report for Build 5874648858

• 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
• 62 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.02%) to 87.246%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
qiskit/transpiler/passes/scheduling/dynamical_decoupling.py	3	4	75.0%

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/expr.rs	1	93.76%
crates/qasm2/src/lex.rs	4	90.89%
qiskit/visualization/state_visualization.py	57	57.55%

Totals
Change from base Build 5861497685:	0.02%
Covered Lines:	74290
Relevant Lines:	85150

---

💛 - Coveralls

[Raghav-Bell]

tox -elint is failing on python qiskit-terra/tools/find_optional_imports.py with ERROR: sympy is imported via qiskit.circuit.quantumcircuit. Any guess how to fix this.

[mtreinish]

tox -elint is failing on python qiskit-terra/tools/find_optional_imports.py with ERROR: sympy is imported via qiskit.circuit.quantumcircuit. Any guess how to fix this.

I assume you're on windows, this is caused by the fact that symengine is an optional dependency on windows because of pip doesn't let us distinguish between 64bit and 32 bit platforms for dependencies (symengine only works with 64bit). If you're running windows 64bit and a 64bit build of python you can do .tox/lint/Scripts/pip install symengine to install tox in the lint environment and then rerun tox -elint to fix that. Otherwise you can just ignore that specific error locally because it won't fail in CI (because CI runs on linux which requires symengine).

[Cryoris]

The changes LGTM, could you add a test to check the fix? You could e.g use the example from #10569 and ensure that it now runs as expected.

[coveralls]

Pull Request Test Coverage Report for Build 6771583945

• 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
• 25 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.02%) to 86.923%

---

Files with Coverage Reduction	New Missed Lines	%
qiskit/extensions/quantum_initializer/squ.py	2	84.15%
crates/qasm2/src/lex.rs	5	91.16%
crates/qasm2/src/parse.rs	18	96.2%

Totals
Change from base Build 6770066582:	-0.02%
Covered Lines:	74343
Relevant Lines:	85527

---

💛 - Coveralls

[dieris]

I'd suggest replacing this block with an assertion. Either just on pm.run(qc), or perhaps on qc.global_phase equal to that of the output circuit

[Raghav-Bell]

I have replaced it with following code block:

self.assertEqual(qc.global_phase + 3.14159265358979, pm.run(qc).global_phase)

But getting following error while testing:

AssertionError: ParameterExpression(a + 3.14159265358979) != ParameterExpression(a + 3.14159265358979)

Can you please help me in debugging this .

[dieris]

how about self.assertEqual(qc.global_phase + np.pi, pm.run(qc).global_phase)?

[Raghav-Bell]

As of deprecation in 0.21 dynamical decoupling is replaced with paddynamical decoupling. These conflicts are due to merge of #10754 . Let me try to fix this.

[jakelishman]

Thanks for this. I've just force-pushed some changes to this to fix up the merge-conflict resolution commits that had gone a bit wrong, but it looks ok to me now.