Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate StochasticSwap #12552

Closed
1 of 4 tasks
1ucian0 opened this issue Jun 12, 2024 · 4 comments · Fixed by #12983
Closed
1 of 4 tasks

deprecate StochasticSwap #12552

1ucian0 opened this issue Jun 12, 2024 · 4 comments · Fixed by #12983
Assignees
@1ucian0
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog type: epic A theme of work that contain sub-tasks
Milestone
1.3.0

Comments

@1ucian0
Copy link
Member

1ucian0 commented Jun 12, 2024 •
edited
Loading

StochasticSwap is currently use in optmization level 0 and superseded by SabreSwap.
@1ucian0 1ucian0 added the Changelog: Deprecation Include in "Deprecated" section of changelog label Jun 12, 2024
@1ucian0 1ucian0 modified the milestones: 2.0.0, 1.3.0, 1.2.0 Jun 12, 2024
@weechinghwa
Copy link
Contributor

Hi, I am interested in taking up this issue.

@1ucian0 1ucian0 self-assigned this Jul 23, 2024
@1ucian0 1ucian0 added the type: epic A theme of work that contain sub-tasks label Jul 23, 2024
@1ucian0
Copy link
Member Author

1ucian0 commented Jul 23, 2024

This is more of an epic than an issue (tagging as such). Would you like to help with any of the items? I can take remove from level 0 in 1.2 because it is time sensitive.

@1ucian0 1ucian0 mentioned this issue Jul 23, 2024
Merged
@weechinghwa
Copy link
Contributor

I am interested in deprecate 1.2/1.3, but this is rather new to me.
Could you provide some keywords or guides to help me understand it thoroughly from A to Z.

@mergify mergify bot mentioned this issue Jul 29, 2024
Merged
@1ucian0
Copy link
Member Author

1ucian0 commented Jul 30, 2024

Could you provide some keywords or guides to help me understand it thoroughly from A to Z.

I think a good starting point is https://github.com/Qiskit/qiskit/blob/main/CONTRIBUTING.md#adding-deprecation-warnings

Feel free to create a draft PR soon, so we can discuss it more concretely.

@mtreinish mtreinish modified the milestones: 1.2.0, 1.3.0 Jul 30, 2024
@danielbultrini danielbultrini mentioned this issue Aug 19, 2024
Merged
@ElePT ElePT linked a pull request Aug 20, 2024 that will close this issue
Deprecates StochasticSwap and suggests the use of SabreSwap #12983
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1ucian0 1ucian0

Labels
Changelog: Deprecation Include in "Deprecated" section of changelog type: epic A theme of work that contain sub-tasks
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Deprecates StochasticSwap and suggests the use of SabreSwap danielbultrini/qiskit
3 participants
@1ucian0 @mtreinish @weechinghwa