Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistencies in the options for the drawer (circuit, and timeline) #11858

Closed
jaygambetta opened this issue Feb 22, 2024 · 1 comment · Fixed by #11878
Closed

inconsistencies in the options for the drawer (circuit, and timeline) #11858

jaygambetta opened this issue Feb 22, 2024 · 1 comment · Fixed by #11878
Assignees
Labels
type: feature request New feature or request
Milestone

Comments

@jaygambetta
Copy link
Member

What should we add?

When I was looking at visualizations for the timeline_drawer and the circuit_drawer it would be good to have both have the same options for the same thing. I.e idle_wires does not work in the timeline and it took me a while to figure out it is show_idle.

To get both to work one use option show_idle and the other idle_wires it would be good to have both have the same name.

timeline_drawer(qc_ibm, show_idle=False)
and
circuit_drawer(qc_ibm, idle_wires=False)

my proposal is make it

timeline_drawer(qc_ibm, idle_wires=False)
and
circuit_drawer(qc_ibm, idle_wires=False)

@jaygambetta jaygambetta added the type: feature request New feature or request label Feb 22, 2024
@1ucian0
Copy link
Member

1ucian0 commented Feb 23, 2024

I agree with your proposal. Let's deprecate timeline_drawer(..., show_idle=...) in favor of timeline_drawer(..., idle_wires =...).

@1ucian0 1ucian0 added the good first issue Good for newcomers label Feb 23, 2024
@github-project-automation github-project-automation bot moved this to Tagged but unassigned in Contributor Monitoring Feb 23, 2024
@1ucian0 1ucian0 removed the good first issue Good for newcomers label Feb 23, 2024
@1ucian0 1ucian0 self-assigned this Feb 23, 2024
@1ucian0 1ucian0 added this to the 1.1.0 milestone Feb 23, 2024
@github-project-automation github-project-automation bot moved this from Tagged but unassigned to Done in Contributor Monitoring Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants