Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flatten option type hint for consistency #10456

Closed
mtreinish opened this issue Jul 20, 2023 · 0 comments · Fixed by #10479
Closed

Fix flatten option type hint for consistency #10456

mtreinish opened this issue Jul 20, 2023 · 0 comments · Fixed by #10479
Assignees
@mtreinish
Milestone
0.25.0

Comments

@mtreinish
Copy link
Member

mtreinish commented Jul 20, 2023 •
edited
Loading

For consistency with the rest of the signature (also the Optional import would need to be removed 🙂)

        flatten: bool | None = None,

Originally posted by @Cryoris in #10269 (comment)

In #10269 the type hints added for the new flatten option were using Optional[bool] it should instead be bool | None. This should be fixed for the final 0.25.0 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtreinish mtreinish

Labels
None yet
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

Consistent typehints for NLocal family Cryoris/qiskit-terra
1 participant
@mtreinish