Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VQD optimal_values result field is incorrect #10263

Closed
woodsp-ibm opened this issue Jun 12, 2023 · 0 comments · Fixed by #10279
Closed

VQD optimal_values result field is incorrect #10263

woodsp-ibm opened this issue Jun 12, 2023 · 0 comments · Fixed by #10279
Assignees
Labels
bug Something isn't working mod: algorithms Related to the Algorithms module

Comments

@woodsp-ibm
Copy link
Member

woodsp-ibm commented Jun 12, 2023

VQD result object has these fields https://github.com/Qiskit/qiskit-terra/blob/c463b3c4741c7532494a583633d2798352fc828e/qiskit/algorithms/eigensolvers/vqd.py#L468-L470

the field optimal_values is incorrectly populated with points not values https://github.com/Qiskit/qiskit-terra/blob/c463b3c4741c7532494a583633d2798352fc828e/qiskit/algorithms/eigensolvers/vqd.py#L445-L451

This can be seen in VQD tutorial where it says it will print 3 energy values, but instead it's 3 lists

image

See Qiskit/qiskit-tutorials#1471 which was to fix the deprecation and I had wondered why the change from using optimal_values as the output from what was checked in seemed fine. The above when its run from the latest VQD, as published out as html, is not though - so something changed since that was ran originally - hence this issue.

@woodsp-ibm woodsp-ibm added bug Something isn't working mod: algorithms Related to the Algorithms module labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mod: algorithms Related to the Algorithms module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants