Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for Expr values through the transpiler pipelines #10234

Closed
Tracked by #10239
jakelishman opened this issue Jun 7, 2023 · 0 comments · Fixed by #10512
Closed
Tracked by #10239

Add testing for Expr values through the transpiler pipelines #10234

jakelishman opened this issue Jun 7, 2023 · 0 comments · Fixed by #10512
Labels
type: qa Issues and PRs that relate to testing and code quality
Milestone

Comments

@jakelishman
Copy link
Member

What should we add?

This is spiritually tracking the work labelled "PR 4" in the initial classical-expression design document.

On a scan through the transpiler passes, the only ones I could immediately see that look like they'll need attention are SabreLayout and SabreSwap, tracked in #10232, but since these don't support control-flow at all yet, there's no immediate issue yet.

This issue can be marked fixed once we've verified that there is support at all control-flow supported optimization_level settings through the transpiler (currently 0 and 1), and have added explicit tests to the suite that these expression values are correctly passed through transpile.

@jakelishman jakelishman added the type: feature request New feature or request label Jun 7, 2023
@jakelishman jakelishman added this to the 0.25.0 milestone Jun 7, 2023
@kdk kdk added type: qa Issues and PRs that relate to testing and code quality and removed type: feature request New feature or request labels Jul 5, 2023
@kdk kdk changed the title Add support for Expr values through the transpiler pipelines Add testing for Expr values through the transpiler pipelines Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants