Fix: Remove set collecting all nodes to be connected.

- A set collecting all the new nodes to connect with a new node was preventing additional wires to connect to subsequent nodes.
Qiskit · Aug 26, 2024 · 74d8b03 · 74d8b03
1 parent 9486158
commit 74d8b03
Showing 1 changed file with 9 additions and 20 deletions.
diff --git a/crates/circuit/src/dag_circuit.rs b/crates/circuit/src/dag_circuit.rs
@@ -6277,8 +6277,6 @@ impl DAGCircuit {
             let new_node = self.dag.add_node(NodeType::Operation(instr));
             new_nodes.push(new_node);
 
-            // For each qubit and cl_bit retrieve the last_nodes
-            let mut nodes_to_connect: HashSet<NodeIndex> = HashSet::default();
             // Check all the qubits in this instruction.
             for qubit in self.qargs_cache.intern(qubits_id) {
                 // Retrieve each qubit's last node
@@ -6296,11 +6294,8 @@ impl DAGCircuit {
                     predecessor_node
                 };
                 qubit_last_nodes.entry(*qubit).or_insert(new_node);
-                if !nodes_to_connect.contains(&qubit_last_node) {
-                    self.dag
-                        .add_edge(qubit_last_node, new_node, Wire::Qubit(*qubit));
-                    nodes_to_connect.insert(qubit_last_node);
-                }
+                self.dag
+                    .add_edge(qubit_last_node, new_node, Wire::Qubit(*qubit));
             }
 
             // Check all the clbits in this instruction.
@@ -6319,11 +6314,8 @@ impl DAGCircuit {
                     predecessor_node
                 };
                 clbit_last_nodes.entry(clbit).or_insert(new_node);
-                if !nodes_to_connect.contains(&clbit_last_node) {
-                    self.dag
-                        .add_edge(clbit_last_node, new_node, Wire::Clbit(clbit));
-                    nodes_to_connect.insert(clbit_last_node);
-                }
+                self.dag
+                    .add_edge(clbit_last_node, new_node, Wire::Clbit(clbit));
             }
 
             // If available, check all the vars in this instruction
@@ -6345,15 +6337,12 @@ impl DAGCircuit {
                 };
 
                 vars_last_nodes.set_item(var, new_node.index())?;
-                if !nodes_to_connect.contains(&var_last_node) {
-                    if var_last_node == new_node {
-                        // TODO: Fix instances of duplicate nodes for Vars
-                        continue;
-                    }
-                    self.dag
-                        .add_edge(var_last_node, new_node, Wire::Var(var.clone_ref(py)));
-                    nodes_to_connect.insert(var_last_node);
+                if var_last_node == new_node {
+                    // TODO: Fix instances of duplicate nodes for Vars
+                    continue;
                 }
+                self.dag
+                    .add_edge(var_last_node, new_node, Wire::Var(var.clone_ref(py)));
             }
         }