Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primitive interface updates for SamplerV2 #1313

Closed
kt474 opened this issue Jan 11, 2024 · 4 comments
Closed

Primitive interface updates for SamplerV2 #1313

kt474 opened this issue Jan 11, 2024 · 4 comments
Labels
priority: high High priority issue (must have for current release) Qiskit 1.0

Comments

@kt474
Copy link
Member

kt474 commented Jan 11, 2024

Part of #1131

Support SamplerV2 input/output:

  • RFC
  • Input/output would also be PUB based
  • Output is per shot measurement, with convenience functions to returns counts/probabilities

Based on the following Qiskit PRs Qiskit/qiskit#11566 (replaced Qiskit/qiskit#11264)

Work should be done off the experimental branch where some of the work is already done (#1224)

@kt474 kt474 added the priority: high High priority issue (must have for current release) label Jan 11, 2024
@kt474
Copy link
Member Author

kt474 commented Jan 16, 2024

cc: @gadial

@drew-distefano
Copy link
Collaborator

@t-imamichi I noticed that Qiskit/qiskit#11566 is in review. Do you have an estimate for when you expect it to close? Once it's complete @gadial will be unblocked on this work.

@ihincks
Copy link
Collaborator

ihincks commented Jan 17, 2024

The BaseSamplerV2 has been closed, and the BaseEstimatorV2 is in the merge queue. My guess is that the runtime repo should not be blocked two state vector implementations (Qiskit/qiskit#11566 and Qiskit/qiskit#11227) but only on BaseEstimatorV2.

That being said, the two state vector implementations will hopefully be merged tomorrow.

This was referenced Jan 21, 2024
@kt474
Copy link
Member Author

kt474 commented Mar 6, 2024

Completed in 0.21.0 release

@kt474 kt474 closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High priority issue (must have for current release) Qiskit 1.0
Projects
None yet
Development

No branches or pull requests

4 participants