Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[After #401] Transpile with pass managers #391

Merged
merged 63 commits into from
Nov 30, 2023
Merged

[After #401] Transpile with pass managers #391

merged 63 commits into from
Nov 30, 2023

Conversation

beckykd
Copy link
Collaborator

@beckykd beckykd commented Nov 21, 2023 •
edited
Loading

Closes #211

@beckykd beckykd requested a review from javabster November 21, 2023 23:42
javabster
javabster requested changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@javabster javabster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far!

docs/transpile/custom_passes.mdx Outdated Show resolved Hide resolved
docs/transpile/custom_passes.mdx Outdated Show resolved Hide resolved
docs/transpile/custom_passes.mdx Outdated Show resolved Hide resolved
docs/transpile/custom_passes.mdx Outdated Show resolved Hide resolved
docs/transpile/custom_passes.mdx Outdated Show resolved Hide resolved
@javabster javabster requested a review from kevinsung November 22, 2023 16:38
@kevinsung kevinsung removed their request for review November 22, 2023 19:32
@kevinsung kevinsung self-assigned this Nov 22, 2023
@kevinsung kevinsung mentioned this pull request Nov 22, 2023
Closed
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@kevinsung kevinsung marked this pull request as draft November 22, 2023 22:48
@kevinsung
Copy link
Collaborator

I just noticed that the file defaults_and_configuration_options.mdx is still a WIP:

** ~~~Question about this: "approximation_degree (float) - Heuristic dial used for circuit approximation (1.0=no >approximation, 0.0=maximal approximation). The default value is 1.0."

It looks like the value is a float in the range [0 - 1]. Should we clarify that in the description? What do the "in between" >measurements mean?**

@beckykd Is this the only remaining issue that needs to be addressed?

javabster
javabster reviewed Nov 23, 2023
View reviewed changes
docs/transpile/customizing-transpilation.ipynb Outdated Show resolved Hide resolved
docs/transpile/customizing-transpilation.ipynb Outdated Show resolved Hide resolved
docs/transpile/customizing-transpilation.ipynb Outdated Show resolved Hide resolved
docs/transpile/customizing-transpilation.ipynb Outdated Show resolved Hide resolved
docs/transpile/customizing-transpilation.ipynb Outdated Show resolved Hide resolved
docs/transpile/customizing-transpilation.ipynb Outdated Show resolved Hide resolved
@abbycross abbycross mentioned this pull request Nov 29, 2023
Closed
2 tasks
@kevinsung kevinsung mentioned this pull request Nov 29, 2023
Closed
5 tasks
@kevinsung
Copy link
Collaborator

do you think we should update the "Transpiler Stages" page as well? Atm it leads with a transpile() narrative, but is there a way to refactor it to fit in better with this passsmanager narrative, like you did for the "Introduction" page?

Done in this PR.

javabster
javabster approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@javabster javabster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kevinsung kevinsung added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit f80e963 Nov 30, 2023
4 checks passed
@kevinsung kevinsung deleted the custom-passes branch November 30, 2023 18:54
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
@beckykd @nbronn
@kevinsung @javabster @abbycross @frankharkins
[After Qiskit#401] Transpile with pass managers (Qiskit#391)
782c427 
Closes Qiskit#211

---------

Co-authored-by: nick bronn <[email protected]>
Co-authored-by: Kevin J. Sung <[email protected]>
Co-authored-by: Kevin J. Sung <[email protected]>
Co-authored-by: Abby Mitchell <[email protected]>
Co-authored-by: abbycross <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankharkins frankharkins frankharkins left review comments

@abbycross abbycross abbycross approved these changes

@kevinsung kevinsung kevinsung left review comments

@javabster javabster javabster approved these changes

Assignees

@kevinsung kevinsung

Labels
None yet
Projects
Docs Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ NEW PAGE ] Customizing transpilation
6 participants
@beckykd @kevinsung @javabster @abbycross @frankharkins @nbronn