Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a js error when secret contains chinese character #193

Closed
liqiangno1 opened this issue Jan 3, 2019 · 3 comments · Fixed by #203
Closed

There is a js error when secret contains chinese character #193

liqiangno1 opened this issue Jan 3, 2019 · 3 comments · Fixed by #203
Assignees
@BennieMeng
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/frontend Categorizes an issue or PR as relevant to sig-frontend.

Comments

@liqiangno1
Copy link

liqiangno1 commented Jan 3, 2019 •
edited
Loading

Describe the bug
当secret中含有中文，发布时js报错，但页面没有任何提示。
我测试过直接在K8S中添加含有中文得secret，可以添加成功，dashboard后台显示乱码，我本地通过api读取到自己解码是没问题得。所以最好支持一下吧

To Reproduce
Steps to reproduce the behavior:

  1. 添加secret模板
  2. 任意添加一个含有中文得项
  3. 点击发布

Expected behavior
支持中文编码

Screenshots
image

Desktop (please complete the following information):

  • OS: windows10
  • Browser chrome

Server Version

- Kubernetes version: 1.12.1
- Wayne version: 1.1
@wilhelmguo wilhelmguo added kind/bug Categorizes issue or PR as related to a bug. sig/frontend Categorizes an issue or PR as relevant to sig-frontend. labels Jan 3, 2019
@BennieMeng
Copy link
Collaborator

is this template should not have chinese message or allow?

@wilhelmguo
Copy link
Collaborator

@846677234 Please change your title to English.

@liqiangno1 liqiangno1 changed the title secret中含有中文时报错 There isa js error when secret contains chinese character Jan 3, 2019
@liqiangno1 liqiangno1 changed the title There isa js error when secret contains chinese character There is a js error when secret contains chinese character Jan 3, 2019
@liqiangno1
Copy link
Author

message

I think it should support chinese message.

@BennieMeng BennieMeng mentioned this issue Jan 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BennieMeng BennieMeng

Labels
kind/bug Categorizes issue or PR as related to a bug. sig/frontend Categorizes an issue or PR as relevant to sig-frontend.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix secret save error when contain chinese character BennieMeng/wayne
3 participants
@liqiangno1 @wilhelmguo @BennieMeng