Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server/queue): get max players via convar for better reliability #553

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix(server/queue): get max players via convar for better reliability #553

merged 1 commit into from
Aug 23, 2024

Conversation

D4isDAVID
Copy link
Member

Description

For some reason GlobalState.MaxPlayers isn't completely reliable and can sometimes be nil, so this gets the convar directly instead.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@mafewtm mafewtm merged commit 19c4ce3 into main Aug 23, 2024
4 checks passed
@mafewtm mafewtm deleted the fix/queue-maxplayers branch August 23, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafewtm mafewtm mafewtm approved these changes

@solareon solareon solareon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@D4isDAVID @solareon @mafewtm