Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use lib.triggerClientEvent #523

Merged
merged 2 commits into from
Jul 25, 2024
Merged

refactor: use lib.triggerClientEvent #523

merged 2 commits into from
Jul 25, 2024

Conversation

solareon
Copy link
Contributor

Description

lib.triggerClientEvent offers improved performance for sending client events to multiple clients. This moves events sent to all clients to lib.triggerClientEvent

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Copy link
Member

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a new lib feature? Do we need to increase the minimum ox_lib version required?

@solareon
Copy link
Contributor Author

Is this a new lib feature? Do we need to increase the minimum ox_lib version required?

Three months old. It's in 3.20.0 and later https://github.com/overextended/ox_lib/blob/master/imports/triggerClientEvent/server.lua

@solareon solareon requested review from mafewtm and FjamZoo July 25, 2024 19:20
Copy link
Member

@mafewtm mafewtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be tested before merging to make sure everything works with this

@FjamZoo FjamZoo merged commit 061e2dd into main Jul 25, 2024
4 checks passed
@FjamZoo
Copy link
Contributor

FjamZoo commented Jul 25, 2024

real men test in prod

solareon added a commit that referenced this pull request Jul 26, 2024
Manason pushed a commit that referenced this pull request Jul 26, 2024
@solareon solareon deleted the lib-triggerclient branch August 3, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants