safe cannot read numbers from the vault on 0.9.9

[scottillogical]

safe get secret/path/default
!! json: cannot unmarshal number into Go struct field vaultResponse.data of type string

We're using a dynamodb backed Vault v0.9.6

Reverting to safe 0.9.6 resolves the issue

Is this because we need to upgrade or vault or something or just a bug? I haven't tried with newer vault versions, yet

[thomasmitchell]

Probably a bug. Safe has never really... dealt with non-strings (you can't write one with safe). We were probably converting ints to strings internally when reading them previously, though. And then I probably rolled right over that by accident when I put in vaultkv as the backing library. I'll fix it.

[scottillogical]

Yeah the values were not added via safe

[jhunt]

Can this be closed?

[thomasmitchell]

Nope.

[Proplex]

We just came across this issue with this command:

safe set auth/approle/role/genesis-pipelines secret_id_ttl=90m token_num_uses=0 token_ttl=90m token_max_ttl=90m secret_id_num_uses=0

Executing it results in !! json: cannot unmarshal number into Go value of type string

Rolling back to v0.9.6 returns the intended result (being able to run this command an arbitrary amount of times and have it successfully generate a new approle token)

Tried with both Vault 0.11.5 and Vault 0.9.3, macOS 10.13.6 and Ubuntu Trusty 14.04.5

[thomasmitchell]

Thanks for the extra example. I very much hope to have this fixed for the next release.

[thomasmitchell]

should be able to read numbers (and booleans and hashes and lists) into strings as of b3bd92f

[scottillogical]

I haven't had a chance to test this and haven't had the issue been reported since so I assume this is good to close thank you Thomas