Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pip in Dockerfile #150

Merged
merged 5 commits into from
Dec 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/container_build_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ jobs:
context: .
push: true
# Start with a limited number of platforms
platforms: linux/amd64,linux/arm64
# ARM builds are (temporarily) removed in release 2.1.3 because pyqubo 1.5.0 is unavailable for this platform
# platforms: linux/amd64,linux/arm64
platforms: linux/amd64
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM python:3.12

RUN pip install --upgrade pip
COPY . .
RUN pip install --default-timeout=1800 -r .settings/requirements_full.txt

Expand Down
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,12 @@ After making sure your docker daemon is running, you can run the container:
docker run -it --rm ghcr.io/quark-framework/quark
```

> __Note__: ARM builds are (temporarily) removed in release 2.1.3 because pyqubo 1.5.0 is unavailable for this platform
> at the moment. This means if you want to run QUARK as a container on a machine with a chip from this
> [list](https://en.wikipedia.org/wiki/List_of_ARM_processors) you might face problems. Please feel free to
> [open an issue](https://github.com/QUARK-framework/QUARK/issues/new), so we can work on a tailored workaround until
> the latest version of pyqubo is available on ARM platforms.

You can also build the docker image locally like:
```
docker build -t ghcr.io/quark-framework/quark .
Expand Down
6 changes: 6 additions & 0 deletions docs/tutorial.rst
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,12 @@ After making sure your docker daemon is running, you can run the container:

docker run -it --rm ghcr.io/quark-framework/quark

**Note**: ARM builds are (temporarily) removed in release 2.1.3 because pyqubo 1.5.0 is unavailable for this platform at
the moment. This means if you want to run QUARK as a container on a machine with a chip from this
`list <https://en.wikipedia.org/wiki/List_of_ARM_processors>`_ you might face problems. Please feel free to `open an
issue <https://github.com/QUARK-framework/QUARK/issues/new>`_, so we can work on a tailored workaround until the latest
version of pyqubo is available on ARM platforms.

You can also build the docker image locally like:

::
Expand Down
6 changes: 3 additions & 3 deletions tests/modules/applications/optimization/MIS/test_MIS.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ def test_process_solution(self):

def test_validate(self):
logging.disable(logging.WARNING)
self.mis_instance.application = nx.Graph()
self.mis_instance.application.add_nodes_from([0, 1, 2])
self.mis_instance.application.add_edges_from([(0, 1), (1, 2)])
self.mis_instance.graph = nx.Graph()
self.mis_instance.graph.add_nodes_from([0, 1, 2])
self.mis_instance.graph.add_edges_from([(0, 1), (1, 2)])

valid_solution = [0, 2]
is_valid, validation_time = self.mis_instance.validate(valid_solution)
Expand Down
Loading