Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PixelData should not be precached #22

Open
pieper opened this issue Sep 19, 2023 · 0 comments
Open

PixelData should not be precached #22

pieper opened this issue Sep 19, 2023 · 0 comments

Comments

@pieper
Copy link
Member

pieper commented Sep 19, 2023

The dicom module uses the plugin's tags member to know which fields to put into the TagCache database:

https://github.com/Slicer/Slicer/blob/bc6482c9a4abaabe3f93b0bfee31d5a8a2c4ae97/Modules/Scripted/DICOM/DICOM.py#L176-L185

But the PETSUV plugin includes PixelData in the tags member:

https://github.com/QIICR/Slicer-PETDICOMExtension/blob/master/DICOMPETSUVPlugin/DICOMPETSUVPlugin.py#L65

This probably leads to a large tag cache and poor performance, although I haven't timed it.

Possibly related to #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pieper