Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The example in the tutorial (Optimal Transport solvers comparison) does not work due to the NotImplementedError #682

Open
RequieMa opened this issue Oct 31, 2024 · 1 comment

Comments

@RequieMa
Copy link

I tried the example in Optimal Transport solvers comparison (https://pythonot.github.io/auto_examples/plot_solve_variants.html#sphx-glr-auto-examples-plot-solve-variants-py)

It gave me NotImplementedError when defining G = ot.solve(M, a, b, **param).plan

NotImplementedError: Not implemented reg_type="KL" and unbalanced_type="tv"

By inspecting the code, it seems that many combinations are ignored in the implementation.

if not isinstance(reg_type, tuple) and reg_type.lower() in ['kl'] and unbalanced_type.lower() == 'kl':

Will that be included in future? Or does it exist in some branches?
(I installed via pip install POT[all], and it seems to installed POT-0.9.3-cp38-cp38-win_amd64.whl)

@rflamary
Copy link
Collaborator

The ot solver comparisaon was introduced in 0.9.4 so your version is out of date. This isa goodfeedback we should probably add "Introduce in POT X.X.X" to the new examples in the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants