Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backports.os fsencode/fsdecode #326

Open
pombredanne opened this issue Feb 11, 2018 · 2 comments
Open

Add backports.os fsencode/fsdecode #326

pombredanne opened this issue Feb 11, 2018 · 2 comments

Comments

@pombredanne
Copy link

pombredanne commented Feb 11, 2018

Pi's backport of os.fsencode and os.fsdecode to Python 2 @ https://github.com/pjdelport/backports.os would be a great addition and is the only backport of these rather complex-to-get-right functions that works on Python 2. (I tested it extensively with https://github.com/nexB/scancode-toolkit and we are planning the Python 3 port aboutcode-org/scancode-toolkit#295 )

I would be a must have in python-future IMHO

@jayvdb
Copy link

jayvdb commented Apr 2, 2019

Its test suite fails fairly comprehensively on AppVeyor ;-)

See PiDelport/backports.os#13

@jayvdb
Copy link

jayvdb commented Apr 3, 2019

Note that a significant part of backports.os is copied exactly from https://github.com/etrepum/pyutf8 . invalid_utf8_indexes is the copied bit.

Its test suite passes on Python 2, but not on Python 3 which is understandable as it hasn't been touched since 2012 , seven years ago, and the code itself hasnt been touched since 2010.

It needs some lovin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants