Create registries.yaml if k3s_registries.mirrors or k3s_registries.configs are not None #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es.configs are not empty
xanmanning
approved these changes
Jun 17, 2023
coolguy1771
referenced
this pull request
in coolguy1771/home-ops
Jun 20, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [xanmanning.k3s](https://togithub.com/PyratLabs/ansible-role-k3s) | role | patch | `v3.4.1` -> `v3.4.2` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>PyratLabs/ansible-role-k3s (xanmanning.k3s)</summary> ### [`v3.4.2`](https://togithub.com/PyratLabs/ansible-role-k3s/releases/tag/v3.4.2) [Compare Source](https://togithub.com/PyratLabs/ansible-role-k3s/compare/v3.4.1...v3.4.2) #### What's Changed - fix: static pods should be deployed to all control nodes by [@​onedr0p](https://togithub.com/onedr0p) in [https://github.com/PyratLabs/ansible-role-k3s/pull/207](https://togithub.com/PyratLabs/ansible-role-k3s/pull/207) - Create registries.yaml if k3s_registries.mirrors or k3s_registries.configs are not None by [@​matteyeux](https://togithub.com/matteyeux) in [https://github.com/PyratLabs/ansible-role-k3s/pull/208](https://togithub.com/PyratLabs/ansible-role-k3s/pull/208) #### New Contributors - [@​matteyeux](https://togithub.com/matteyeux) made their first contribution in [https://github.com/PyratLabs/ansible-role-k3s/pull/208](https://togithub.com/PyratLabs/ansible-role-k3s/pull/208) **Full Changelog**: PyratLabs/ansible-role-k3s@v3.4.1...v3.4.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMjQuNCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Jul 27, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [xanmanning.k3s](https://github.com/PyratLabs/ansible-role-k3s) | role | minor | `v3.3.1` -> `v3.4.2` | --- ### Release Notes <details> <summary>PyratLabs/ansible-role-k3s (xanmanning.k3s)</summary> ### [`v3.4.2`](https://github.com/PyratLabs/ansible-role-k3s/releases/tag/v3.4.2) [Compare Source](PyratLabs/ansible-role-k3s@v3.4.1...v3.4.2) #### What's Changed - fix: static pods should be deployed to all control nodes by [@​onedr0p](https://github.com/onedr0p) in PyratLabs/ansible-role-k3s#207 - Create registries.yaml if k3s_registries.mirrors or k3s_registries.configs are not None by [@​matteyeux](https://github.com/matteyeux) in PyratLabs/ansible-role-k3s#208 #### New Contributors - [@​matteyeux](https://github.com/matteyeux) made their first contribution in PyratLabs/ansible-role-k3s#208 **Full Changelog**: PyratLabs/ansible-role-k3s@v3.4.1...v3.4.2 ### [`v3.4.1`](https://github.com/PyratLabs/ansible-role-k3s/blob/HEAD/CHANGELOG.md#2023-05-17-v341) [Compare Source](PyratLabs/ansible-role-k3s@v3.4.0...v3.4.1) ##### Notable changes - fix: resolve ansible lint warnings and fix molecule tests in github actions ##### Contributors - [dbrennand](https://github.com/dbrennand) *** ### [`v3.4.0`](https://github.com/PyratLabs/ansible-role-k3s/blob/HEAD/CHANGELOG.md#2023-03-11-v340) [Compare Source](PyratLabs/ansible-role-k3s@v3.3.1...v3.4.0) ##### Notable changes - refactor: add `until: 1.23.15` to `secrets-encryption` from `k3s_experimental_config` as it is no longer experimental. Fixes [#​200](PyratLabs/ansible-role-k3s#200). - docs(fix): typo in `CONTRIBUTING.md` ##### Contributors - [dbrennand](https://github.com/dbrennand) *** </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yMy4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: Nicolas Dufour <[email protected]> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/11 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create registries.yaml if k3s_registries.mirrors or k3s_registries.configs are not None
Summary
The task
Ensure containerd registriesis run whenk3s_registries is defined, butk3s_registriesis always defined in defaults. This then creates a yaml file with null values for configs and mirrors :It can be problematic if there is already a
registries.yamlfile present and it's overwritten by the role.This MR adds a two conditions when importing the task. The task is imported only if
k3s_registries.mirrorsork3s_registries.configsare not None. Both values are set to None by default.Fixes #205
Issue type
Test instructions
If
registriesvariable is not set (in the inventory or in a playbook) then the taskEnsure containerd registries file existsis skipped and{{ k3s_config_dir }}/registries.yamlis not created.Acceptance Criteria
Additional Information